-
Notifications
You must be signed in to change notification settings - Fork 61
telemetry(amazonq): add metrics for code symbols, chat history and export #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe64bb8 to
b3fa82f
Compare
| { | ||
| "name": "exportFormat", | ||
| "type": "string", | ||
| "allowedValues": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can reuse filenameExt
aws-toolkit-common/telemetry/definitions/commonDefinitions.json
Lines 1265 to 1269 in df56506
| { | |
| "name": "filenameExt", | |
| "type": "string", | |
| "description": "Filename extension (examples: .txt, .yml, .yaml, .asl.yaml, ...), or empty string if the filename does not contain dot (.) between two chars." | |
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| "export", | ||
| "open", | ||
| "delete" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have action that can be reused here unless we have strong reason for prefix:
aws-toolkit-common/telemetry/definitions/commonDefinitions.json
Lines 18 to 21 in df56506
| { | |
| "name": "action", | |
| "type": "string", | |
| "description": "Name of an action that was taken, displayed, etc. See also `userChoice`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no thats fine, i can switch it to the existing action type
|
Ready to merge, ty |
## Problem New telemetry metrics were [added](aws/aws-toolkit-common#1023) to aws-toolkit-common ## Solution Consume latest version of aws-toolkit-common package
Problem
@Codeadded to messages by usersSolution
Add the following metrics:
To measure code symbol use, add the following types to amazonq_addMessage metric:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.